Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redo new-match #7823

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 5, 2020

Description

Frontend

  • redoes page in vue with needed validation
  • allowed pledger to create pledge
    • multiple grant types + categories
    • multiple collections
  • pledger can choose to ask for more details / pay upfront (payment only in DAI)
  • If pay upfront -> there is a message notifying that signature for transaction will be prompted
  • Once successfully paid -> txn is recorded and new backend API is invoked

Backend

  • auto creates entry in MatchPledge
  • auto creates entry in GrantCLR and set to inactive if payment is done (the matchplege record is linked to this as well)
  • CLR code is updated to accommodate CLR for collections

Closes #7784

Testing

https://share.vidyard.com/watch/srB8rfwhtWsu98HH7nvwDz?

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure but I think if you select type you should clear or not send collections and also the opposite to not end with a pledge entry with type and collections just one or the other.

@thelostone-mc
Copy link
Member Author

Ah yes good point! I missed that 🙌

@thelostone-mc
Copy link
Member Author

@octavioamu comments addressed

  • prompt wallet connect if provider is null
  • clear form on submit data successfully
  • clear type+category when collection is selected and vice versa

@thelostone-mc thelostone-mc merged commit f5d7e23 into gitcoinco:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants