Fix error in /tip for non-logged in user #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiantf
requested review from
amustapha,
chibie,
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
sebastiantf
changed the title
4 tasks
PixelantDesign
approved these changes
Nov 25, 2020
|
@sebastiantf a neater way to go about this would be to add the @login_required decorator in views.py file |
|
@thelostone-mc When Also, Should I revert this commit and use the decorator? |
amustapha
approved these changes
Nov 26, 2020
@sebastiantf yup would be cleaner ! plus there is no reason for folks to use /tiop without being logged in |
sebastiantf
force-pushed
the
fix/recent-tips
branch
from
22b9896
to
5d61759
Compare
@thelostone-mc Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #7830
Fixes showing this error for non-logged-in user:
Refers/Fixes
#7830 (comment)
Screenshot
This user is not logged in: