Make active CLR rounds togglable #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amustapha
requested review from
chibie,
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
amustapha
force-pushed
the
abdul/fix/make-active-clrs-collapsible
branch
from
b8327dc
to
7fd0ae0
Compare
amustapha
force-pushed
the
abdul/fix/make-active-clrs-collapsible
branch
from
7fd0ae0
to
bcc3769
Compare
|
@aamustapha could you cherry-pick your changes and raise a pR |
amustapha
force-pushed
the
abdul/fix/make-active-clrs-collapsible
branch
from
bcc3769
to
0f44e3f
Compare
chibie
approved these changes
Dec 3, 2020
danlipert
approved these changes
Dec 8, 2020
thelostone-mc
approved these changes
Dec 9, 2020
octavioamu
reviewed
Dec 9, 2020
| @@ -162,6 +162,7 @@ if (document.getElementById('grants-showcase')) { | |||
| page: 1, | |||
| collectionsPage: 1, | |||
| limit: 6, | |||
| show_active_clrs: window.localStorage.getItem('show_active_clrs') != 'false', | |||
There was a problem hiding this comment.
false string? seems to me this will be === true
There was a problem hiding this comment.
maybe you should use JSON.parse(window.localStorage.idx_status = 'false')
and also handle when there is not localstorage show_active_clrs to avoid errors
There was a problem hiding this comment.
Anyway works
default null > true
'false' > false
anything > true
but in general I feel is better when we deal with booleans to keep it booleans
octavioamu
suggested changes
Dec 9, 2020
| @@ -162,6 +162,7 @@ if (document.getElementById('grants-showcase')) { | |||
| page: 1, | |||
| collectionsPage: 1, | |||
| limit: 6, | |||
| show_active_clrs: window.localStorage.getItem('show_active_clrs') != 'false', | |||
There was a problem hiding this comment.
maybe you should use JSON.parse(window.localStorage.idx_status = 'false')
and also handle when there is not localstorage show_active_clrs to avoid errors
octavioamu
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displaying active CLR rounds at the top of the Grant's page helps users to easily navigate to a spceicific CLR round they're interested in. However, in a case where there are several active CLR rounds, probably above 5, the interface easily becomes cluttered up.
This PR adds a toggle functionality to the Active CLR rounds banner at the top of the page.
Refers/Fixes
Testing
https://www.loom.com/share/8bab707e0d80440e9fe3505abda5ca20