Default to an Encoding without BOM when BOM marker was not found #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStream
methods attempts detecting encoding by checking forBOM
at the beginning of the stream. When that fails a call toAutoDetect
is made. Given thatAutoDetect
is entered knowing thatBOM
was not found, an Encoding ofStreamReader
that it uses should be withoutBOM
.This doesn't impact reading the file but it does impact the receiving/consuming end of a
StreamReader
where a code might check what encoding is set on a givenStreamReader
to use the same encoding for saving edited file which would lead to incorrectly addingBOM
.StreamReader
constructor defaults toEncoding.UTF8
which has BOM thus encoding used to create a file doesn't match encoding set on theStreamReader