t/perf: fix broken tests #1330
t/perf: fix broken tests #1330
Conversation
Fix multi-threaded 'p0004' test's use of the 'REPO_BIG_ENOUGH_FOR_MULTI' prerequisite. Unlike normal 't/' tests, 't/perf/' tests need to have their prerequisites declared with the '--prereq' flag. Signed-off-by: Victoria Dye <vdye@github.com>
In the 'p0006' test "read-tree br_base br_ballast", move the '-n' flag used in 'git read-tree' ahead of its positional arguments. Signed-off-by: Victoria Dye <vdye@github.com>
|
/submit |
|
Submitted as pull.1330.git.1660942149.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| ' | ||
|
|
||
| test_perf "single-threaded, $desc" " | ||
| test-tool lazy-init-name-hash --single --count=$count |
There was a problem hiding this comment.
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Victoria Dye <vdye@github.com>
>
> Fix multi-threaded 'p0004' test's use of the 'REPO_BIG_ENOUGH_FOR_MULTI'
> prerequisite. Unlike normal 't/' tests, 't/perf/' tests need to have their
> prerequisites declared with the '--prereq' flag.
>
> Signed-off-by: Victoria Dye <vdye@github.com>
> ---
> t/perf/p0004-lazy-init-name-hash.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks. It is unfortunate that we need to live with this seemingly
unnecessary deviation.
> diff --git a/t/perf/p0004-lazy-init-name-hash.sh b/t/perf/p0004-lazy-init-name-hash.sh
> index 1afc08fe7f1..85be14e4ddb 100755
> --- a/t/perf/p0004-lazy-init-name-hash.sh
> +++ b/t/perf/p0004-lazy-init-name-hash.sh
> @@ -49,7 +49,7 @@ test_perf "single-threaded, $desc" "
> test-tool lazy-init-name-hash --single --count=$count
> "
>
> -test_perf REPO_BIG_ENOUGH_FOR_MULTI "multi-threaded, $desc" "
> +test_perf "multi-threaded, $desc" --prereq REPO_BIG_ENOUGH_FOR_MULTI "
> test-tool lazy-init-name-hash --multi --count=$count
> "
|
This branch is now known as |
|
This patch series was integrated into seen via git@e6534b9. |
|
This patch series was integrated into seen via git@b2cd103. |
|
There was a status update in the "New Topics" section about the branch Rather trivial perf-test code fixes. Will merge to 'next'. source: <pull.1330.git.1660942149.gitgitgadget@gmail.com> |
|
This patch series was integrated into seen via git@8bfb8fe. |
|
This patch series was integrated into seen via git@6043214. |
|
This patch series was integrated into next via git@e68356e. |
|
This patch series was integrated into seen via git@52062dc. |
|
This patch series was integrated into seen via git@6371cda. |
|
There was a status update in the "Cooking" section about the branch Rather trivial perf-test code fixes. Will merge to 'master'. source: <pull.1330.git.1660942149.gitgitgadget@gmail.com> |
|
This patch series was integrated into seen via git@61eab6f. |
|
This patch series was integrated into seen via git@78a6d2f. |
|
There was a status update in the "Cooking" section about the branch Rather trivial perf-test code fixes. Will merge to 'master'. source: <pull.1330.git.1660942149.gitgitgadget@gmail.com> |
|
This patch series was integrated into seen via git@2540220. |
|
This patch series was integrated into master via git@2540220. |
|
This patch series was integrated into next via git@2540220. |
|
Closed via 2540220. |
This series fixes two performance tests (p0004 & p0006) with syntax issues preventing them from running properly. Since these are pretty straightforward syntax bugs, the fixes don't seem to change the intended behavior of the tests.
Thanks!