Make GPG errors less puzzling #1480
Conversation
This test case not only increases test coverage in setups without working gpg, but also prepares for verifying that the error message of `gpg.program` is shown upon failure. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
There are few things more frustrating when signing a commit fails than reading a terse "error: gpg failed to sign the data" message followed by the unsurprising "fatal: failed to write commit object" message. In many cases where signing a commit or tag fails, `gpg` actually said something helpful, on its stderr, and Git even consumed that, but then keeps mum about it. Teach Git to stop withholding that rather important information. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
/submit |
|
Submitted as pull.1480.git.1676440714.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| @@ -977,9 +977,13 @@ static int sign_buffer_gpg(struct strbuf *buffer, struct strbuf *signature, | |||
| break; /* found */ | |||
There was a problem hiding this comment.
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> ret |= !cp;
> + if (ret) {
> + error(_("gpg failed to sign the data:\n%s"),
> + gpg_status.len ? gpg_status.buf : "(no gpg output)");
> + strbuf_release(&gpg_status);
> + return -1;
> + }
> strbuf_release(&gpg_status);
> - if (ret)
> - return error(_("gpg failed to sign the data"));
Good. As we are worried about error messages that are too terse,
dumping everything to the output would be a vast improvement.
Hopefully gpg_status.len would to be thousands of bytes long, and
this is not a codepath that is triggered remotely anyway.
Will queue. Thanks.
|
This branch is now known as |
|
This patch series was integrated into seen via git@26c4ad1. |
|
This patch series was integrated into seen via git@006a6ed. |
|
This patch series was integrated into next via git@510898f. |
|
This patch series was integrated into seen via git@e10923d. |
|
This patch series was integrated into seen via git@ac463d6. |
|
There was a status update in the "New Topics" section about the branch Error messages given upon a signature verification failure used to discard the errors from underlying gpg program, which has been corrected. Will merge to 'master'. source: <pull.1480.git.1676440714.gitgitgadget@gmail.com> |
|
This patch series was integrated into seen via git@4180fb8. |
|
This patch series was integrated into seen via git@38a227b. |
|
This patch series was integrated into master via git@38a227b. |
|
This patch series was integrated into next via git@38a227b. |
|
Closed via 38a227b. |
For one times too many, I was asked to help with a commit signing problem where the only error message was an unhelpful:
That was it. No further indication what went wrong. And certainly not that wonderful error message that the helper that was configured as
gpg.programwrote to itsstderr.Let's show whatever GPG (or any alternative configured via
gpg.program) had to say when signing failed.