Skip to content

Conversation

phil-blain
Copy link

The new FAQ is not listed in command-list.txt, so it does not show up in git help --guides.

I think this should be included in 2.27.0.

CC: brian m. carlson sandals@crustytoothpaste.net

When 'gitfaq.txt' was added in 2149b67 (docs: add a FAQ, 2020-03-30),
it was added to the Makefile but not to command-list.txt.

Add it there also, so that the new FAQ is listed in the output of
`git help --guides`.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
@phil-blain
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented May 20, 2020

@gitgitgadget
Copy link

gitgitgadget bot commented May 20, 2020

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
>
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for sharp eyes.

Will queue, but it may be post -rc1.

@gitgitgadget
Copy link

gitgitgadget bot commented May 20, 2020

This branch is now known as bc/faq.

@gitgitgadget
Copy link

gitgitgadget bot commented May 20, 2020

This patch series was integrated into pu via git@ab24bde.

@gitgitgadget gitgitgadget bot added the pu label May 20, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented May 21, 2020

On the Git mailing list, "brian m. carlson" wrote (reply to this):


--dwN3S3mscniL3FCL
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2020-05-20 at 14:44:48, Philippe Blain via GitGitGadget wrote:
> From: Philippe Blain <levraiphilippeblain@gmail.com>
>=20
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
>=20
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for catching this.  This seems obviously correct.
--=20
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

--dwN3S3mscniL3FCL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.2.20 (GNU/Linux)

iHUEABYKAB0WIQQILOaKnbxl+4PRw5F8DEliiIeigQUCXsXfDwAKCRB8DEliiIei
gQ2YAQDtoAu3Ot9/rzdhFz/zahvAhDtSFS63/Yo4fIqjHA9V/gD9EZdel0WuTIAe
dGEJS0tT2TWfLYjXTx4WZuercbvEvA8=
=noR9
-----END PGP SIGNATURE-----

--dwN3S3mscniL3FCL--

@gitgitgadget
Copy link

gitgitgadget bot commented May 21, 2020

This patch series was integrated into pu via git@56eec21.

@gitgitgadget
Copy link

gitgitgadget bot commented May 21, 2020

This patch series was integrated into pu via git@72d398a.

@gitgitgadget
Copy link

gitgitgadget bot commented May 21, 2020

This patch series was integrated into next via git@ab3fc8f.

@gitgitgadget gitgitgadget bot added the next label May 21, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented May 25, 2020

This patch series was integrated into pu via git@80e013c.

@gitgitgadget
Copy link

gitgitgadget bot commented May 25, 2020

This patch series was integrated into next via git@80e013c.

@gitgitgadget
Copy link

gitgitgadget bot commented May 25, 2020

This patch series was integrated into master via git@80e013c.

@gitgitgadget gitgitgadget bot added the master label May 25, 2020
@gitgitgadget gitgitgadget bot closed this May 25, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented May 25, 2020

Closed via 80e013c.

@phil-blain phil-blain deleted the list-faq-in-guides branch August 17, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant