README.md 생성 및 프로젝트 세팅 #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
previously approved these changes
Aug 1, 2024
간단하게 구현해보았습니다.
|
BeA-Pro
approved these changes
Aug 3, 2024
shgusgh12
approved these changes
Aug 3, 2024
ytaek
approved these changes
Aug 3, 2024
Comment on lines
+13
to
+15
| ui, ux, interaction 쪽에 강한 프론트엔드 개발자가 되는게 꿈입니다! ㅎㅎ | ||
|
|
||
| 함께 으쌰으쌰하면서 친목도 쌓고, 더 좋은 오픈소스 만들어 나갔으면 좋겠습니다. 읽어주셔서 감사합니다! No newline at end of file |
Comment on lines
+12
to
+19
| ChartJS.register( | ||
| RadialLinearScale, | ||
| PointElement, | ||
| LineElement, | ||
| Filler, | ||
| Tooltip, | ||
| Legend, | ||
| ); |
There was a problem hiding this comment.
다음에 기회가 되면 d3로 바로 도전해보시는 것도 좋겠습니다!!
어차피 chart들도 기본 rect, circle, line, text 등의 컴포넌들로 이뤄진 집합이라,
개인적으로 CSS보다 훨씬 쉬운 것 같습니다 😈😈😈
There was a problem hiding this comment.
오 그렇군요! 저는 그냥 제일 간단하다고 해서 가장 빨리 구현할 수 있을 것 같아 골랐는데 ㅎㅎ 다음에 한 번 도전해보겠습니다!!
PR 규칙도 새롭게 알았습니다 알려주셔서 감사합니다!
commit들 모은 담에 올려서 pr하고 또 다음에 모아서 pr하면 따로따로 올라가는 줄 알았네요..ㅎㅎ
There was a problem hiding this comment.
ㅎㅎ 넵 머지하고 나면 따로 올라가게 됩니다!
머지 안하면 계속 해당 PR 뒤로 붙게 되구요~
There was a problem hiding this comment.
넵! 숙지하겠습니다 🫡 githru vs ext에선 그렇게 진행해보겠습니다! :D
|
@BeA-Pro 넵 처음이라 많이 떨리네요 ㅎㅎ 감사합니다!! 햄스터같이 생기지 않았나요 🐹 |
|
@shgusgh12 저도 잘 부탁드립니다 화이팅화이팅~~!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm create vite@latestComments