Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZenScript language support #4471

Merged
merged 12 commits into from
May 10, 2019
Merged

Add ZenScript language support #4471

merged 12 commits into from
May 10, 2019

Conversation

jaredlll08
Copy link
Contributor

Description

ZenScript is a scripting language for Java. It is primarily used by CraftTweaker, which is a Minecraft mod that allows users to change many aspects of the game using scripts.

Many of the projects which use CraftTweaker (and in turn use ZenScript) are open source and on GitHub. It is not uncommon for these repos to solely consist of ZenScript files. Having syntax highlighting as well as language break downs for it would be very useful for these projects.

Checklist:

  • I am adding a new language.
    • I have included a syntax highlighting grammar: Lightshow (Lightshow is currently offline, but I have tested this syntax on it before and it worked perfectly fine)
    • I have updated the heuristics to distinguish my language from others using the same extension.
      • No other languages use the .zs extension.

@jaredlll08
Copy link
Contributor Author

I'm not exactly sure how to fix the Travis issues, I haven't changed the license since it was made, so not sure how the cached data is out of date.

@pchaigno
Copy link
Contributor

@jaredlll08 Thanks for your contribution! Do you get an error message if you run script/licensed?

@lildude Any idea what's happening to Lightshow?

@jaredlll08
Copy link
Contributor Author

@pchaigno No error message, but I think that fixed the cache issue, lets wait and see what Travis says.

@jaredlll08
Copy link
Contributor Author

Yip that seems to have solved it! Thanks!

@jaredlll08
Copy link
Contributor Author

No idea on that error, I don't think it is anything I did, maybe it is due to that one repo (https://github.com/ajLangley12/language-asn1) not being available anymore?

@lildude
Copy link
Member

lildude commented Mar 31, 2019

No idea on that error, I don't think it is anything I did, maybe it is due to that one repo (https://github.com/ajLangley12/language-asn1) not being available anymore?

Yup, looks like @ajlangley has 🔥 the ajLangley12 user and thus access to the repo too. @ajlangley is this intentional? If so, we'll probably need to find a new grammar for ASN.1 - https://github.com/sparticvs/atom-language-asn1 might be a good alternative - or maintain a fork of the repo ourselves.

@ajlangley
Copy link
Contributor

ajlangley commented Mar 31, 2019

It was not my intention to make a breaking change to this repository, but I did deletey asn grammar repository yesterday while doing some general cleanup of my account. I did not understand that it could not be safely deleted and that that was the only place where the package existed.

@ajlangley
Copy link
Contributor

Contacted support, repo is restored.

@jaredlll08
Copy link
Contributor Author

The username is still different, so the submodule will still fail. Not sure if this is something I need to fix in this PR, or if it will be handled by someone else.

@lildude
Copy link
Member

lildude commented Apr 1, 2019

Not sure if this is something I need to fix in this PR, or if it will be handled by someone else.

It's best to update the submodule path in a new PR.

@jaredlll08
Copy link
Contributor Author

I was more saying I wasn't sure if I needed to fix the submodule so that the Travis tests pass (to be honest nothing has changed that would invalidate the previous tests that were done), so that this PR can get merged.

@lildude
Copy link
Member

lildude commented Apr 1, 2019

@jaredlll08 merging master into your fork should solve the CI problems now.

@jaredlll08
Copy link
Contributor Author

That seems to have solved it! Thanks!

@jaredlll08
Copy link
Contributor Author

Not sure if I'm missing something, but would appreciate if this could get a review :)

@lildude
Copy link
Member

lildude commented May 10, 2019

@jaredlll08 looks like we've got some conflicts that need resolving now.

@jaredlll08
Copy link
Contributor Author

@lildude should be good :)

@lildude lildude requested a review from pchaigno May 10, 2019 09:41
@lildude lildude requested a review from Alhadis May 10, 2019 09:41
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 :shipit:

@lildude lildude removed the request for review from pchaigno May 10, 2019 09:48
@lildude lildude merged commit 1e8687c into github-linguist:master May 10, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants