-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZenScript language support #4471
Conversation
I'm not exactly sure how to fix the Travis issues, I haven't changed the license since it was made, so not sure how the cached data is out of date. |
@jaredlll08 Thanks for your contribution! Do you get an error message if you run @lildude Any idea what's happening to Lightshow? |
@pchaigno No error message, but I think that fixed the cache issue, lets wait and see what Travis says. |
Yip that seems to have solved it! Thanks! |
No idea on that error, I don't think it is anything I did, maybe it is due to that one repo (https://github.com/ajLangley12/language-asn1) not being available anymore? |
Yup, looks like @ajlangley has 🔥 the |
It was not my intention to make a breaking change to this repository, but I did deletey asn grammar repository yesterday while doing some general cleanup of my account. I did not understand that it could not be safely deleted and that that was the only place where the package existed. |
Contacted support, repo is restored. |
The username is still different, so the submodule will still fail. Not sure if this is something I need to fix in this PR, or if it will be handled by someone else. |
It's best to update the submodule path in a new PR. |
I was more saying I wasn't sure if I needed to fix the submodule so that the Travis tests pass (to be honest nothing has changed that would invalidate the previous tests that were done), so that this PR can get merged. |
@jaredlll08 merging master into your fork should solve the CI problems now. |
That seems to have solved it! Thanks! |
Not sure if I'm missing something, but would appreciate if this could get a review :) |
@jaredlll08 looks like we've got some conflicts that need resolving now. |
@lildude should be good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Description
ZenScript is a scripting language for Java. It is primarily used by CraftTweaker, which is a Minecraft mod that allows users to change many aspects of the game using scripts.
Many of the projects which use CraftTweaker (and in turn use ZenScript) are open source and on GitHub. It is not uncommon for these repos to solely consist of ZenScript files. Having syntax highlighting as well as language break downs for it would be very useful for these projects.
Checklist:
.zs
extension.