Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment highlighting to VSCode language configs #4514

Merged
merged 1 commit into from
May 10, 2019
Merged

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Apr 29, 2019

Low-hanging fruit. Registers language-configuration.json as a "JSON with Comments" format, fixing the glaring error highlighting in many VSCode grammar packages. E.g., stuff like this.

Checklist:

  • I am associating a language with a new file extension.
    • The new extension is used in hundreds of repositories on GitHub.com
    • I have included a real-world usage sample for all extensions added in this PR:

/cc @pchaigno for quick review.

@Alhadis Alhadis merged commit f01ef78 into master May 10, 2019
@Alhadis Alhadis deleted the vscode-jsonc branch May 10, 2019 09:19
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants