Navigation Menu

Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

GitHub context menus show up when in non-github repos #301

Closed
shana opened this issue May 16, 2016 · 3 comments
Closed

GitHub context menus show up when in non-github repos #301

shana opened this issue May 16, 2016 · 3 comments
Assignees
Labels

Comments

@shana
Copy link
Contributor

shana commented May 16, 2016

Reported by @acangialosi

When working on a project hosted on VSTS, GitHub Create/Copy link context menus are showing up, and they shouldn't be.

@paladique
Copy link
Contributor

paladique commented May 27, 2016

I made a new project, uploaded that to VSTS and was able to reproduce this.
2016-05-27 2

Other scenarios where context menu still shows up

  1. Logged out of extension, even after restarting

@femisimon
Copy link

femisimon commented Oct 24, 2016

Description

Files not hosted on GitHub when user isn't logged in shouldn't provide the following GitHub Context Menu Option:

  • Open on Github
  • Copy link to clipboard

Although clicking on the options generates a 404 page on dot com, Our manifest requires this options not to be visible in this scenario.

GitHub Extension version: v2.0.15.1
Visual Studio version: 14.0.25424.00 Update 3

Steps to reproduce

  • Launch VS and log out if already logged in
  • Open a C# file that isn't hosted on GitHub
  • Select any text in c# file and Right-click.
  • Open on Github and Copy link to clipboard is visible in the context menu

Expected result - Open on Github and Copy link to clipboard should not be visible in the context menu

Actual result - Open on Github and Copy link to clipboard is visible in the context menu

@grokys
Copy link
Contributor

grokys commented Feb 15, 2017

Seems to be fixed.

@grokys grokys closed this as completed Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants