New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub context menus show up when in non-github repos #301

Closed
shana opened this Issue May 16, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@shana
Collaborator

shana commented May 16, 2016

Reported by @acangialosi

When working on a project hosted on VSTS, GitHub Create/Copy link context menus are showing up, and they shouldn't be.

@paladique

This comment has been minimized.

Show comment
Hide comment
@paladique

paladique May 27, 2016

Collaborator

I made a new project, uploaded that to VSTS and was able to reproduce this.
2016-05-27 2

Other scenarios where context menu still shows up

  1. Logged out of extension, even after restarting
Collaborator

paladique commented May 27, 2016

I made a new project, uploaded that to VSTS and was able to reproduce this.
2016-05-27 2

Other scenarios where context menu still shows up

  1. Logged out of extension, even after restarting
@femisimon

This comment has been minimized.

Show comment
Hide comment
@femisimon

femisimon Oct 24, 2016

Description

Files not hosted on GitHub when user isn't logged in shouldn't provide the following GitHub Context Menu Option:

  • Open on Github
  • Copy link to clipboard

Although clicking on the options generates a 404 page on dot com, Our manifest requires this options not to be visible in this scenario.

GitHub Extension version: v2.0.15.1
Visual Studio version: 14.0.25424.00 Update 3

Steps to reproduce

  • Launch VS and log out if already logged in
  • Open a C# file that isn't hosted on GitHub
  • Select any text in c# file and Right-click.
  • Open on Github and Copy link to clipboard is visible in the context menu

Expected result - Open on Github and Copy link to clipboard should not be visible in the context menu

Actual result - Open on Github and Copy link to clipboard is visible in the context menu

femisimon commented Oct 24, 2016

Description

Files not hosted on GitHub when user isn't logged in shouldn't provide the following GitHub Context Menu Option:

  • Open on Github
  • Copy link to clipboard

Although clicking on the options generates a 404 page on dot com, Our manifest requires this options not to be visible in this scenario.

GitHub Extension version: v2.0.15.1
Visual Studio version: 14.0.25424.00 Update 3

Steps to reproduce

  • Launch VS and log out if already logged in
  • Open a C# file that isn't hosted on GitHub
  • Select any text in c# file and Right-click.
  • Open on Github and Copy link to clipboard is visible in the context menu

Expected result - Open on Github and Copy link to clipboard should not be visible in the context menu

Actual result - Open on Github and Copy link to clipboard is visible in the context menu

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Feb 15, 2017

Contributor

Seems to be fixed.

Contributor

grokys commented Feb 15, 2017

Seems to be fixed.

@grokys grokys closed this Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment