New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful enterprise login doesn't close signup modal if error on other tab #309

mponce1 opened this Issue May 18, 2016 · 0 comments


None yet
1 participant

mponce1 commented May 18, 2016

Steps to reproduce:

  1. Go to GHfVS signin screen
  2. On the Github tab, produce an incorrect password
  3. On Enterprise tab, sign in

Expected result: Signin modal closes after any successful login.
Actual result: Signin modal stays open if there's an error on github tab.

@mponce1 mponce1 added the bug label May 18, 2016

grokys added a commit that referenced this issue May 20, 2016

Use Merge instead of Amb on login control.
Fixes #309. `Observable.Amb` "emits all of the items from only the first
of these Observables to emit an item or notification". This means that
if the user tries to login first to .com with an invalid login, then
tries to login to enterprise with a valid login the login from
enterprise will be ignored because the .com observable fired first.
Instead use `Observable.Merge` which will emit authentication results
from both in any order.

grokys added a commit that referenced this issue May 20, 2016

Add unit test for #309
Confirmed that the unit test fails on master but passes with the fix.

@shana shana closed this in #316 May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment