New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not being cleared after checkout pull request succeeds #786

Closed
jcansdale opened this Issue Jan 18, 2017 · 3 comments

Comments

Projects
2 participants
@jcansdale
Contributor

jcansdale commented Jan 18, 2017

  • GitHub Extension for Visual Studio version: 2.2.04
  • Visual Studio version: Enterprise 2015

What happened

  1. Opened GitHub repo in Visual Studio
  2. Clicked 'Pull Requests' button
  3. Selected pull request
  4. Clicked on 'Checkout [pull-request-name]' link
  5. Checkout failed (not sure why this happened):

checkout

  1. Checkout subsequently succeeded
  2. Error message was not cleared

Expected Behavior

Error message cleared when checkout succeeds.

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Jan 31, 2017

Contributor

Here's a different, but possibly related issue:

  1. Open a solution with uncommitted changes
  2. Open a PR
  3. The 'Checkout' link is disabled because of the uncommitted changes
  4. Right click and 'undo changes' on changes files in 'Team Explorer'
  5. The link remains disabled

uncommited

It is possible to refresh, but it wasn't immediately obvious.

(just making notes as I go along)

Contributor

jcansdale commented Jan 31, 2017

Here's a different, but possibly related issue:

  1. Open a solution with uncommitted changes
  2. Open a PR
  3. The 'Checkout' link is disabled because of the uncommitted changes
  4. Right click and 'undo changes' on changes files in 'Team Explorer'
  5. The link remains disabled

uncommited

It is possible to refresh, but it wasn't immediately obvious.

(just making notes as I go along)

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Jan 31, 2017

Contributor

Trying to repro but came across this: #823

Contributor

jcansdale commented Jan 31, 2017

Trying to repro but came across this: #823

@grokys grokys added this to Not Started in 2.2.0.8 Feb 2, 2017

jcansdale added a commit that referenced this issue Feb 8, 2017

@paladique paladique moved this from Not Started to In Progress in 2.2.0.8 Feb 10, 2017

jcansdale added a commit that referenced this issue Feb 13, 2017

jcansdale added a commit that referenced this issue Feb 13, 2017

@grokys grokys moved this from In Progress to Done in 2.2.0.8 Feb 13, 2017

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Feb 15, 2017

Contributor

Closed by #842.

Contributor

grokys commented Feb 15, 2017

Closed by #842.

@grokys grokys closed this Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment