This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Handle inline comments in projection buffers. #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were crashing trying to show inline comments when a projection buffer was opened in a diff. Don't crash, and actually show inline comments. Fixes #1186
grokys
changed the title
`.cshtml` files have a projection buffer which is the contents of the generated C#. Don't use this as a content source for diff matching as it's completely different to the file in git.
grokys
changed the title
|
Before this fix: After this fix: Seems to be working! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were crashing trying to show inline comments when a projection buffer (such as a
.cshtmlfile) was opened in a diff. Don't crash, and actually show inline comments.Fixes #1186