This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Make Navigate to Editor more discoverable #1552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR gives users a hint that the Navigate to Editor functionality exists.
It adds the following messages:
When a PR file diff gets focus

When a PR file diff gets focus from a PR that isn't checked out

When user attempts to navigate to a file that isn't checked out

When the diff file focus is lost the status is cleared (showing the default

Ready
message)View File
to view a (read-only) PR fileReviewers
Todo
Finalize the wording. Would something like this be better?Press Enter to navigate to Editor (PR branch must be checked out)
Checkout
andCancel
options~~~Maybe do this ina separate PRPart of #1491
Fixes #1546