This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Show clone URL tab by default (A/B testing) #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following counters for tracking the clone view being opened with different selected tabs: NumberOfCloneViewGitHubTab NumberOfCloneViewEnterpriseTab NumberOfCloneViewUrlTab
Check the correct default tab is being selected and the NumberOfCloneView*Tab counters are being incremented.
StanleyGoldman
approved these changes
Sep 21, 2018
Utility method to find the incremented counter as a string.
jcansdale
force-pushed
the
fixes/327-default-url-tab-AB-testing
branch
from
b72a552 to
8fa09e5
Compare
Check NumberOfGitHubClones and NumberOfEnterpriseClones are being incremented separately. Expect failing tests on this commit.
Record GitHub and GitHub Enterprise clones separately.
When the assert fails it will look like this:
```
Test
'IncrementCounter_Showing_Default_Tab("https://enterprise.com",True,1,"xxx")'
failed:
NSubstitute.Exceptions.ReceivedCallsException : Expected to receive
exactly 1 call matching:
IncrementCounter(x => (Convert(x.Body).Member.Name ==
value(GitHub.App.UnitTests.ViewModels.Dialog.Clone.RepositoryCloneViewModelTests+<>c__DisplayClass2_0).counterName))
Actually received no matching calls.
Received 1 non-matching call (non-matching arguments indicated with '*'
characters):
IncrementCounter(*model => model.NumberOfCloneViewUrlTab*)
```
StanleyGoldman
approved these changes
Sep 24, 2018
|
This looks great to me, thanks @jcansdale! Really love all the new metrics about which tabs of the dialog are viewed/opened and the number of clones. |
grokys
approved these changes
Sep 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
NumberOfCloneView*Tabcounter when Clone dialog is displayedTODO
NumberOfGitHubClonesandNumberOfEnterpriseClonesA/B Testing
The counters are intended to answer the following questions about showing the clone URL tab by default:
How to test
The Start Page button
%USERPROFILE%\AppData\Local\GìtHūbVisualStudio\user.jsonUserGuidthat ends with an even number will be group A (and odd ones group B)Start Page > Open > GitHubbuttonURLtab should be selectedGitHuborEnterprisetab should be selectedUserGuid, restart Visual Studio and repeat the steps aboveThe Team Explorer - Connect buttons
Manage Connectionsbutton on theTeam Explorertool barCloneon either the GitHub or GitHub Enterprise sectionNumberOfCloneViewGitHubTab,NumberOfCloneViewEnterpriseTaborNumberOfCloneViewUrlTabcounter should increment (depending on which tab is selected by default)NumberOfClonesandNumberOfGitHubClones/NumberOfEnterpriseClonescounters should increment (depending on what type of repository as cloned)Note: the counters will appear in the log when
Enable Trace Loggingis checkedAssumptions
UserGuidis randomRelated