Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validation display on Create Repository dialog #2308

Merged
merged 5 commits into from Apr 5, 2019

Conversation

@StanleyGoldman
Copy link
Contributor

commented Mar 29, 2019

Related #2264

Depends on:

  • #2252 being merged to master

image

image

image

image

StanleyGoldman added some commits Apr 5, 2019

@@ -107,17 +107,21 @@
Grid.Column="1"
MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}"
Text="{Binding RepositoryName, UpdateSourceTrigger=PropertyChanged}"
SpellCheck.IsEnabled="True"

This comment has been minimized.

Copy link
@jcansdale

jcansdale Apr 5, 2019

Collaborator

It looks like spell checking has been disabled. Was this by design?

This comment has been minimized.

Copy link
@StanleyGoldman

StanleyGoldman Apr 5, 2019

Author Contributor

Yea, I disabled it, when I couldn't type VisualStudio without it calling that an error, I decided that it was not useful...

This comment has been minimized.

Copy link
@jcansdale

jcansdale Apr 5, 2019

Collaborator

Lol, makes sense. Though I'm perfectly capable of misspelling the name of my repo. 😉

This comment has been minimized.

Copy link
@jcansdale

jcansdale Apr 5, 2019

Collaborator

It look like dotcom also has spell checking disabled fro this field.

image

This comment has been minimized.

Copy link
@Loki777m
@StanleyGoldman

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Added screenshots

@jcansdale
Copy link
Collaborator

left a comment

Looks good. 😄

I tested with the dark theme...
image

@jcansdale jcansdale merged commit 56c347b into master Apr 5, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190405.21 succeeded
Details

@jcansdale jcansdale deleted the fixes/repository-creation-view-errors branch Apr 5, 2019

@StanleyGoldman StanleyGoldman added the bug label Apr 11, 2019

@StanleyGoldman StanleyGoldman changed the title Fixing validation on create repository dialog Fixing validation display on Create Repository dialog Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.