This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Descriptive Pull Request Creation Errors #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //TODO:Will need a uniform solution to HTTP exception message handling | ||
| var apiException = ex as ApiValidationException; | ||
| var error = apiException?.ApiError?.Errors?.FirstOrDefault(); | ||
| notifications.ShowError(error.Message ?? ex.Message); |
There was a problem hiding this comment.
error can be null here, so it'll throw if you do error.Message, you need to null check there as well.
|
🚀 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this specific instance, we notify the user when they are trying to a duplicate PR on a branch, but with just a "Validation Failed" message. A more informative message lies within the response from the exception. If the type of exception is checked (like
APIValidationException), we can convert and grab the actual message we want to convey to the user. If it's not that type (it's null), then just display the exception message.Fixes #453