This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix crasher when creating a PR with nothing in the body #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| vm.PRTitle = title; | ||
|
|
||
| await vm.CreatePullRequest.ExecuteAsync(); | ||
| ms.Received().CreatePullRequest(repository, vm.PRTitle, String.Empty, vm.SourceBranch, vm.TargetBranch); |
There was a problem hiding this comment.
I think the warning here can be suppressed by appending e.g. var unused =.
There was a problem hiding this comment.
Or maybe just doing await there, it might still complain without it
There was a problem hiding this comment.
That won't work - the method is on a mock so it won't return anything to await.
shana
force-pushed
the
fixes/477-crash-pr-empty-body
branch
from
73f4789 to
bdd9b97
Compare
jcansdale
added a commit
that referenced
this pull request
Nov 7, 2019
Remove dependency on private script submodule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477