New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for checkbox not propagating changes to KeepPrivate property #64

Merged
merged 3 commits into from Sep 1, 2015

Conversation

Projects
None yet
3 participants
@shiftkey
Member

shiftkey commented Sep 1, 2015

Proposed fix for #62 by observing the events directly

  • still have to bind the property to the VM somehow.
  • testing testing testing
workaround for checkbox not propagating changes to KeepPrivate property
We made an assumption here that the CheckBox IsChecked property
would update the property on the viewmodel, but this isn't working
when the user control is hosted in the Team Explorer panel.

@shiftkey shiftkey changed the title from workaround for checkbox not propagating changes to KeepPrivate property to [WIP] workaround for checkbox not propagating changes to KeepPrivate property Sep 1, 2015

@Haacked

View changes

Show outdated Hide outdated src/GitHub.VisualStudio/UI/Views/Controls/RepositoryPublishControl.xaml.cs

@shiftkey shiftkey changed the title from [WIP] workaround for checkbox not propagating changes to KeepPrivate property to workaround for checkbox not propagating changes to KeepPrivate property Sep 1, 2015

@Haacked

This comment has been minimized.

Show comment
Hide comment
@Haacked

Haacked Sep 1, 2015

Member

does your binding need an UpdateSourceTrigger maybe

@gulbanana We're not using XAML bindings. We're using ReactiveUI bindings. Note that the Bind method we used here is the same one we use in the repository create control: https://github.com/github/VisualStudio/blob/master/src/GitHub.VisualStudio/UI/Views/Controls/RepositoryCreationControl.xaml.cs#L50

It works over there, but not here for some reason.

Member

Haacked commented Sep 1, 2015

does your binding need an UpdateSourceTrigger maybe

@gulbanana We're not using XAML bindings. We're using ReactiveUI bindings. Note that the Bind method we used here is the same one we use in the repository create control: https://github.com/github/VisualStudio/blob/master/src/GitHub.VisualStudio/UI/Views/Controls/RepositoryCreationControl.xaml.cs#L50

It works over there, but not here for some reason.

@shiftkey

This comment has been minimized.

Show comment
Hide comment
@shiftkey

shiftkey Sep 1, 2015

Member

Ready for review.

Member

shiftkey commented Sep 1, 2015

Ready for review.

@Haacked

This comment has been minimized.

Show comment
Hide comment
@Haacked

Haacked Sep 1, 2015

Member

😢

Thanks for the fix @shiftkey!

Member

Haacked commented Sep 1, 2015

😢

Thanks for the fix @shiftkey!

Haacked added a commit that referenced this pull request Sep 1, 2015

Merge pull request #64 from shiftkey/checked-does-not-propagate
workaround for checkbox not propagating changes to KeepPrivate property

@Haacked Haacked merged commit a523bf9 into github:master Sep 1, 2015

1 check passed

GitHub CLA @shiftkey has accepted the GitHub Contributor License Agreement.
Details
@gulbanana

This comment has been minimized.

Show comment
Hide comment
@gulbanana

gulbanana Sep 1, 2015

ah, ok. i've definitely experienced weird partial-supportedness with the IsChecked dependencyproperty before but that was using {Binding}, not reactiveui.

gulbanana commented Sep 1, 2015

ah, ok. i've definitely experienced weird partial-supportedness with the IsChecked dependencyproperty before but that was using {Binding}, not reactiveui.

@shiftkey shiftkey deleted the shiftkey:checked-does-not-propagate branch Sep 1, 2015

shana added a commit that referenced this pull request Sep 1, 2015

Revert "Merge pull request #64 from shiftkey/checked-does-not-propagate"
This reverts commit a523bf9, reversing
changes made to 56511e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment