Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 2, 2025

This PR removes @types packages that are no longer needed because their corresponding dependencies now ship their own TypeScript definitions.

Changes

Removed the following redundant @types packages from devDependencies:

  • @types/get-folder-size: The get-folder-size package (v5.0.0) now includes its own TypeScript definitions at index.d.ts with proper exports configuration
  • @types/uuid: The uuid package (v11.1.0) now ships comprehensive TypeScript definitions in dist/cjs/*.d.ts files

Verification

  • ✅ TypeScript compilation passes without errors
  • ✅ All 529 tests continue to pass
  • ✅ ESLint passes with no warnings
  • ✅ Full build completes successfully

Impact

This change reduces the dependency footprint by removing packages that provide duplicate type information. The built-in type definitions from the actual packages are more accurate and up-to-date than the separate @types packages.

Other @types packages (for archiver, console-log-level, follow-redirects, js-yaml, node-forge, semver, and sinon) remain as their corresponding packages do not yet ship their own TypeScript definitions.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: henrymercer <14129055+henrymercer@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Remove any @types packages that are no longer needed because the dependency that they are typing now ships its own types. For example, get-folder-size now ships its own types so we don't need @types/get-folder-size. Remove redundant @types packages that now ship their own TypeScript definitions Sep 2, 2025
Copilot finished work on behalf of henrymercer September 2, 2025 17:39
@Copilot Copilot AI requested a review from henrymercer September 2, 2025 17:39
@henrymercer henrymercer marked this pull request as ready for review September 2, 2025 17:40
@henrymercer henrymercer requested a review from a team as a code owner September 2, 2025 17:40
@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 17:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes redundant @types packages for dependencies that now ship their own TypeScript definitions, reducing the dependency footprint and avoiding duplicate type information.

  • Removes @types/get-folder-size and @types/uuid from devDependencies
  • Relies on built-in TypeScript definitions from the actual packages
  • Maintains other @types packages that are still needed

@henrymercer henrymercer requested a review from mbg September 2, 2025 17:41
@henrymercer henrymercer merged commit 47454d9 into main Sep 2, 2025
274 checks passed
@henrymercer henrymercer deleted the copilot/fix-e885529e-2505-445e-8390-e2c6c91256a4 branch September 2, 2025 18:17
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants