Skip to content

Fix upload-sarif not uploading non-.sarif files #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Fix upload-sarif not uploading non-.sarif files #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
022d7d5
Move error checks out of `getSarifFilePaths`
mbg Sep 26, 2025
9753473
Warn if no SARIF files were uploaded
mbg Sep 25, 2025
fc88436
Move `findAndUpload` to new `upload-sarif` module
mbg Sep 25, 2025
c1f21e4
Use `getSarifFilePaths` in `upload-sarif`
mbg Sep 26, 2025
ff35963
Move main `upload-sarif` logic to new `upload-sarif` module
mbg Sep 25, 2025
d7509a4
Use `FeatureEnablement` rather than `Features` in `upload-sarif`
mbg Sep 25, 2025
4c60b18
Add some tests for `findAndUpload` and `uploadSarif`
mbg Sep 25, 2025
0e1ad53
Fix `sarif-ids` format not matching documentation
mbg Sep 26, 2025
f6ff68d
Test that uploaded files match expectations for each analysis kind
mbg Sep 26, 2025
320fdb3
Tests: ensure `uploadSpecifiedFiles` wasn't called if we don't expect…
mbg Sep 26, 2025
b26519c
Add `isOtherAnalysisSarif` with tests
mbg Sep 26, 2025
7b7f47d
Check that file doesn't belong to other analysis in `getSarifFilePaths`
mbg Sep 26, 2025
e080dc8
Check if file is `.quality.sarif` for CQ upload
mbg Sep 26, 2025
4989465
Merge branch 'main' into mbg/fix/upload-sarif-non-sarif
mbg Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/__upload-quality-sarif.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 21 additions & 17 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 21 additions & 17 deletions lib/init-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

70 changes: 45 additions & 25 deletions lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading