-
Notifications
You must be signed in to change notification settings - Fork 393
Merge main into releases/v3 #3161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Direct tracing is now enabled by default.
There isn't really anything platform-specific at the moment.
Mergeback v3.30.4 refs/heads/releases/v3 into main
Don't dry-run `rollback-release` workflow on release branches
Only run PR checks on Ubuntu by default
Improve `pr-checks` workflow
Add `npm run ava` command, update instructions, and exclude files from VSCode search
and add it to the `build` command
Add script to check whether `npm i` needs to be run
Fix `tools: linked` log message
Don't run `npm install` when in an Actions workflow
Hotfix `upload-sarif` not uploading non-`.sarif` files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a release PR merging changes from main into the releases/v3 branch for version 3.30.5. The primary purpose is to fix a bug introduced in version 3.30.4 where the upload-sarif functionality was incorrectly rejecting files without a .sarif
extension.
Key changes:
- Fixed upload-sarif logic to properly handle code-scanning analysis files without .sarif extensions
- Code organization improvements in setup-codeql.ts (moved code block to better location)
- Simplified PR check workflow configurations by removing redundant OS specifications and consolidating test configurations
Reviewed Changes
Copilot reviewed 70 out of 72 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/upload-sarif-action.ts | Fixed conditional logic to accept code-scanning files without .sarif extension |
src/setup-codeql.ts | Moved forceShippedTools logic block to execute after nightly tools handling |
scripts/check-node-modules.sh | Added new script to conditionally run npm install based on package-lock.json state |
package.json | Updated version to 3.30.5 and refactored npm scripts for better modularity |
pr-checks/sync.py | Removed function and logic for OS/version exclusions, simplified default OS to ubuntu-only |
pr-checks/checks/*.yml | Removed redundant operatingSystems specifications, consolidated test configurations |
CHANGELOG.md | Added entry documenting the upload-sarif bug fix |
Multiple lib/*.js files | Generated JavaScript reflecting the TypeScript source changes |
Files not reviewed (1)
- package-lock.json: Language not supported
Merging 0a67bd4 into
releases/v3
.Conductor for this PR is @mbg.
Contains the following pull requests:
tools: linked
log message #3139 (@henrymercer)rollback-release
workflow on release branches #3151 (@mbg)npm run ava
command, update instructions, and exclude files from VSCode search #3152 (@mbg)pr-checks
workflow #3153 (@mbg)npm i
needs to be run #3154 (@mbg)npm install
when in an Actions workflow #3155 (@mbg)upload-sarif
not uploading non-.sarif
files #3160 (@mbg)Please do the following:
releases/v3
branch.Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.