Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Oct 6, 2025

This renames the upload-quality-sarif check to upload-sarif and covers more cases.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg marked this pull request as ready for review October 6, 2025 15:15
@mbg mbg requested a review from a team as a code owner October 6, 2025 15:15
@mbg mbg requested review from Copilot and henrymercer October 6, 2025 15:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the upload-sarif testing by replacing the basic upload-quality-sarif test with a more comprehensive upload-sarif test that covers multiple analysis kinds. The changes also refactor the uploadPayload function to accept an analysis configuration object instead of just a target parameter.

  • Expands test coverage for upload-sarif functionality across different analysis kinds (code-scanning, code-quality, and combined scenarios)
  • Refactors the uploadPayload function signature to use analysis configuration objects for better payload file naming in test mode
  • Updates test verification scripts to use the new analysis-specific payload file naming convention

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/upload-lib.ts Changes uploadPayload function signature and updates payload file naming in test mode
pr-checks/checks/upload-sarif.yml New comprehensive test covering multiple upload-sarif scenarios
pr-checks/checks/upload-quality-sarif.yml Removes old basic upload-quality-sarif test
pr-checks/checks/with-checkout-path.yml Updates payload file reference to use new naming convention
lib/*.js files Generated JavaScript code reflecting the TypeScript changes
.github/workflows/*.yml Generated workflow files from the updated test templates

@mbg mbg merged commit 239d7b2 into main Oct 7, 2025
241 checks passed
@mbg mbg deleted the mbg/pr-checks/upload-sarif branch October 7, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants