Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A2-3-1: Reports StringLiterals incorrectly #311

Closed
lcartey opened this issue May 23, 2023 · 0 comments · Fixed by #493
Closed

A2-3-1: Reports StringLiterals incorrectly #311

lcartey opened this issue May 23, 2023 · 0 comments · Fixed by #493
Assignees
@rvermeulen
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Low user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@lcartey
Copy link
Collaborator

lcartey commented May 23, 2023 •
edited
Loading

Affected rules

  • A2-3-1

Description

This rule has an exception:

It is permitted to use other characters inside the text of a wide string and a UTF-8 encoded string literal.

This rule is currently implemented as two queries, one of which covers the StringLiteral case and reports all string literals. We should exclude L".." an u8".." strings.
@lcartey lcartey added false positive/false negative An issue related to observed false positives or false negatives. Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards labels May 23, 2023
@rvermeulen rvermeulen self-assigned this Jan 10, 2024
@rvermeulen rvermeulen mentioned this issue Jan 18, 2024
Merged
30 tasks
@ravikprasad ravikprasad added this to the v2.9.0 milestone Jan 22, 2024
@lcartey lcartey removed this from the v2.9.0 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvermeulen rvermeulen

Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Low user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Coding Standards Public Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A2-3-1: Exclude wide string literals and utf8 string literals rvermeulen/codeql-coding-standards
3 participants
@rvermeulen @lcartey @ravikprasad