Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A8-4-8: Allow output parameters in assign operators #370

Closed
lcartey opened this issue Oct 2, 2023 · 1 comment · Fixed by #515
Closed

A8-4-8: Allow output parameters in assign operators #370

lcartey opened this issue Oct 2, 2023 · 1 comment · Fixed by #515
Assignees
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@lcartey
Copy link
Collaborator

lcartey commented Oct 2, 2023

Affected rules

  • A8-4-8

Description

Output parameters are required for user defined assign operators, and so should not be reported.

Example

constexpr byte& operator|=(byte& lhs, const byte rhs) noexcept {
  lhs = (lhs | rhs);
  return lhs;
}
@lcartey lcartey added Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards labels Oct 2, 2023
@rvermeulen rvermeulen self-assigned this Jan 10, 2024
@rvermeulen
Copy link
Collaborator

Cannot reproduce this case. Needs further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Development

Successfully merging a pull request may close this issue.

2 participants