Integrate QCC Into Compiler Testing Framework #249

jsinglet · 2023-03-13T17:59:43Z

Description

Integrates qcc into compiler testing framework for c and c++.

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

github-actions · 2023-03-13T18:00:04Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-13T18:01:12Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:01:17Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:02:22Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:03:33Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:03:56Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-13T18:54:54Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-13T18:58:00Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:58:17Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : Pointers2
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : ARR39-C
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
SUITE                : CERT-C

jsinglet · 2023-03-13T18:58:17Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:58:39Z

🤖 Beep Boop! qcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T18:58:48Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


SUITE                : CERT-C
PACKAGE              : Pointers2
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
RULE                 : ARR39-C
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer

github-actions · 2023-03-13T19:05:58Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-13T19:08:06Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
TEST_PASS            : True
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
PACKAGE              : Pointers2
SUITE                : CERT-C
TEST_DIFFERENCE      : 
RULE                 : ARR39-C
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-03-13T19:09:14Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T19:09:16Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T19:09:57Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
TEST_PASS            : True
RULE                 : ARR39-C
PACKAGE              : Pointers2

jsinglet · 2023-03-13T19:10:14Z

🤖 Beep Boop! qcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : ARR39-C
TEST_PASS            : False
PACKAGE              : Pointers2
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,13 +1,13 @@
                        edges
                        | test.c:7:13:7:14 | p1 | test.c:9:9:9:10 | p1 |
                       -| test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset |
                       -| test.c:16:19:16:41 | ... - ... | test.c:29:6:29:11 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:29:6:29:11 | offset |
                        | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size |
                        | test.c:29:6:29:11 | offset | test.c:7:13:7:14 | p1 |
                        nodes
                        | test.c:7:13:7:14 | p1 | semmle.label | p1 |
                        | test.c:9:9:9:10 | p1 | semmle.label | p1 |
                       -| test.c:16:19:16:41 | ... - ... | semmle.label | ... - ... |
                       +| test.c:16:19:16:41 | __builtin_offsetof | semmle.label | __builtin_offsetof |
                        | test.c:17:17:17:26 | sizeof(<expr>) | semmle.label | sizeof(<expr>) |
                        | test.c:18:26:18:31 | offset | semmle.label | offset |
                        | test.c:23:9:23:12 | size | semmle.label | size |
                       @@ -16,8 +16,8 @@
                        | test.c:29:6:29:11 | offset | semmle.label | offset |
                        subpaths
                        #select
                       -| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | ... - ... | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       -| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                       +| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | __builtin_offsetof | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       +| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                        | test.c:23:9:23:12 | size | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size | Scaled integer used in pointer arithmetic. |
                        | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                        | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                       [1/1 comp 50.5s eval 1.9s] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.qlref
                       
SUITE                : CERT-C
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-03-13T19:10:33Z

🤖 Beep Boop! qcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T19:11:05Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-13T19:12:52Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-13T19:14:05Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T19:14:06Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T19:14:11Z

🤖 Beep Boop! qcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T19:14:50Z

🤖 Beep Boop! qcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : ARR39-C
SUITE                : CERT-C
TEST_PASS            : False
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,13 +1,13 @@
                        edges
                        | test.c:7:13:7:14 | p1 | test.c:9:9:9:10 | p1 |
                       -| test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset |
                       -| test.c:16:19:16:41 | ... - ... | test.c:29:6:29:11 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:29:6:29:11 | offset |
                        | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size |
                        | test.c:29:6:29:11 | offset | test.c:7:13:7:14 | p1 |
                        nodes
                        | test.c:7:13:7:14 | p1 | semmle.label | p1 |
                        | test.c:9:9:9:10 | p1 | semmle.label | p1 |
                       -| test.c:16:19:16:41 | ... - ... | semmle.label | ... - ... |
                       +| test.c:16:19:16:41 | __builtin_offsetof | semmle.label | __builtin_offsetof |
                        | test.c:17:17:17:26 | sizeof(<expr>) | semmle.label | sizeof(<expr>) |
                        | test.c:18:26:18:31 | offset | semmle.label | offset |
                        | test.c:23:9:23:12 | size | semmle.label | size |
                       @@ -16,8 +16,8 @@
                        | test.c:29:6:29:11 | offset | semmle.label | offset |
                        subpaths
                        #select
                       -| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | ... - ... | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       -| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                       +| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | __builtin_offsetof | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       +| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                        | test.c:23:9:23:12 | size | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size | Scaled integer used in pointer arithmetic. |
                        | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                        | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                       [1/1 comp 49.4s eval 1.8s] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.qlref
                       
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
COMPILE_PASS         : True
PACKAGE              : Pointers2

jsinglet · 2023-03-13T19:14:53Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : CERT-C
RULE                 : ARR39-C
PACKAGE              : Pointers2

jsinglet · 2023-03-13T20:27:51Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-13T20:28:28Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


SUITE                : CERT-C
RULE                 : ARR39-C
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
TEST_DIFFERENCE      : 
PACKAGE              : Pointers2
COMPILE_PASS         : True
TEST_PASS            : True

jsinglet · 2023-03-13T20:31:01Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


SUITE                : CERT-C
PACKAGE              : Pointers2
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
TEST_PASS            : False
COMPILE_PASS         : True
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,13 +1,13 @@
                        edges
                        | test.c:7:13:7:14 | p1 | test.c:9:9:9:10 | p1 |
                       -| test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset |
                       -| test.c:16:19:16:41 | ... - ... | test.c:29:6:29:11 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:29:6:29:11 | offset |
                        | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size |
                        | test.c:29:6:29:11 | offset | test.c:7:13:7:14 | p1 |
                        nodes
                        | test.c:7:13:7:14 | p1 | semmle.label | p1 |
                        | test.c:9:9:9:10 | p1 | semmle.label | p1 |
                       -| test.c:16:19:16:41 | ... - ... | semmle.label | ... - ... |
                       +| test.c:16:19:16:41 | __builtin_offsetof | semmle.label | __builtin_offsetof |
                        | test.c:17:17:17:26 | sizeof(<expr>) | semmle.label | sizeof(<expr>) |
                        | test.c:18:26:18:31 | offset | semmle.label | offset |
                        | test.c:23:9:23:12 | size | semmle.label | size |
                       @@ -16,8 +16,8 @@
                        | test.c:29:6:29:11 | offset | semmle.label | offset |
                        subpaths
                        #select
                       -| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | ... - ... | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       -| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                       +| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | __builtin_offsetof | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       +| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                        | test.c:23:9:23:12 | size | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size | Scaled integer used in pointer arithmetic. |
                        | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                        | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                       [1/1 comp 45.1s eval 1.6s] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.qlref
                       
RULE                 : ARR39-C

jsinglet · 2023-03-13T20:31:21Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-14T14:54:38Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-14T14:55:56Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T14:56:42Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
RULE                 : ARR39-C
SUITE                : CERT-C
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Pointers2
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer

jsinglet · 2023-03-14T14:57:39Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T14:57:39Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T14:58:27Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
RULE                 : ARR39-C
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_PASS            : True
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
PACKAGE              : Pointers2

jsinglet · 2023-03-14T14:59:46Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
COMPILE_PASS         : True
PACKAGE              : Pointers2
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,13 +1,13 @@
                        edges
                        | test.c:7:13:7:14 | p1 | test.c:9:9:9:10 | p1 |
                       -| test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset |
                       -| test.c:16:19:16:41 | ... - ... | test.c:29:6:29:11 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:29:6:29:11 | offset |
                        | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size |
                        | test.c:29:6:29:11 | offset | test.c:7:13:7:14 | p1 |
                        nodes
                        | test.c:7:13:7:14 | p1 | semmle.label | p1 |
                        | test.c:9:9:9:10 | p1 | semmle.label | p1 |
                       -| test.c:16:19:16:41 | ... - ... | semmle.label | ... - ... |
                       +| test.c:16:19:16:41 | __builtin_offsetof | semmle.label | __builtin_offsetof |
                        | test.c:17:17:17:26 | sizeof(<expr>) | semmle.label | sizeof(<expr>) |
                        | test.c:18:26:18:31 | offset | semmle.label | offset |
                        | test.c:23:9:23:12 | size | semmle.label | size |
                       @@ -16,8 +16,8 @@
                        | test.c:29:6:29:11 | offset | semmle.label | offset |
                        subpaths
                        #select
                       -| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | ... - ... | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       -| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                       +| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | __builtin_offsetof | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       +| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                        | test.c:23:9:23:12 | size | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size | Scaled integer used in pointer arithmetic. |
                        | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                        | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                       [1/1 comp 51.9s eval 1.8s] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.qlref
                       
TEST_PASS            : False
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
RULE                 : ARR39-C

jsinglet · 2023-03-14T15:00:00Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

lcartey

One minor comment improvement, but otherwise looks good 👍

scripts/matrix_testing/CompileFixTool.ps1

…nto jsinglet/enable-qcc-testing

github-actions · 2023-03-14T17:12:55Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-14T17:15:58Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T17:15:58Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T17:16:07Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T17:16:42Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
PACKAGE              : Pointers2
SUITE                : CERT-C
RULE                 : ARR39-C
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True

jsinglet · 2023-03-14T17:16:46Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
RULE                 : ARR39-C
PACKAGE              : Pointers2
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
TEST_DIFFERENCE      :

jsinglet · 2023-03-14T17:18:28Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


RULE                 : ARR39-C
SUITE                : CERT-C
QUERY                : DoNotAddOrSubtractAScaledIntegerToAPointer
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Pointers2
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,13 +1,13 @@
                        edges
                        | test.c:7:13:7:14 | p1 | test.c:9:9:9:10 | p1 |
                       -| test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset |
                       -| test.c:16:19:16:41 | ... - ... | test.c:29:6:29:11 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset |
                       +| test.c:16:19:16:41 | __builtin_offsetof | test.c:29:6:29:11 | offset |
                        | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size |
                        | test.c:29:6:29:11 | offset | test.c:7:13:7:14 | p1 |
                        nodes
                        | test.c:7:13:7:14 | p1 | semmle.label | p1 |
                        | test.c:9:9:9:10 | p1 | semmle.label | p1 |
                       -| test.c:16:19:16:41 | ... - ... | semmle.label | ... - ... |
                       +| test.c:16:19:16:41 | __builtin_offsetof | semmle.label | __builtin_offsetof |
                        | test.c:17:17:17:26 | sizeof(<expr>) | semmle.label | sizeof(<expr>) |
                        | test.c:18:26:18:31 | offset | semmle.label | offset |
                        | test.c:23:9:23:12 | size | semmle.label | size |
                       @@ -16,8 +16,8 @@
                        | test.c:29:6:29:11 | offset | semmle.label | offset |
                        subpaths
                        #select
                       -| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | ... - ... | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       -| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                       +| test.c:9:9:9:10 | p1 | test.c:16:19:16:41 | __builtin_offsetof | test.c:9:9:9:10 | p1 | Scaled integer used in pointer arithmetic. |
                       +| test.c:18:26:18:31 | offset | test.c:16:19:16:41 | __builtin_offsetof | test.c:18:26:18:31 | offset | Scaled integer used in pointer arithmetic. |
                        | test.c:23:9:23:12 | size | test.c:17:17:17:26 | sizeof(<expr>) | test.c:23:9:23:12 | size | Scaled integer used in pointer arithmetic. |
                        | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | test.c:25:9:25:18 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                        | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | test.c:27:17:27:26 | sizeof(<expr>) | Scaled integer used in pointer arithmetic. |
                       [1/1 comp 52s eval 2s] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.qlref
                       
TEST_PASS            : False

jsinglet · 2023-03-14T17:18:41Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

integrate qcc

d05ebba

tset

a25aa96

test

544c1ba

fix

7ecd4e3

Merge branch 'main' into jsinglet/enable-qcc-testing

a74bc87

jsinglet enabled auto-merge March 14, 2023 17:10

lcartey approved these changes Mar 14, 2023

View reviewed changes

scripts/matrix_testing/CompileFixTool.ps1 Outdated Show resolved Hide resolved

jsinglet added 2 commits March 14, 2023 13:12

fix!

a7c8d74

Merge remote-tracking branch 'upstream/jsinglet/enable-qcc-testing' i…

193a76a

…nto jsinglet/enable-qcc-testing

jsinglet added this pull request to the merge queue Mar 14, 2023

Merged via the queue into main with commit 51da3b1 Mar 14, 2023

jsinglet deleted the jsinglet/enable-qcc-testing branch March 14, 2023 18:59

nicolaswill mentioned this pull request Jan 25, 2024

Missing attestations: @lcartey #501

Open

Integrate QCC Into Compiler Testing Framework #249

Integrate QCC Into Compiler Testing Framework #249

Conversation

jsinglet commented Mar 13, 2023

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

github-actions bot commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

jsinglet commented Mar 13, 2023

github-actions bot commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

lcartey left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023

jsinglet commented Mar 14, 2023