Implement OutOfBounds package #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcartey
previously requested changes
Mar 30, 2023
added 8 commits
April 5, 2023 21:32
rvermeulen
reviewed
Apr 6, 2023
rvermeulen
reviewed
Apr 6, 2023
|
I've refactored |
|
/test-performance |
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
jsinglet
previously requested changes
Apr 7, 2023
There was a problem hiding this comment.
@kraiouchkine -- I think this is going to require some performance work. It's currently running at about double the baseline: https://github.com/github/codeql-coding-standards-release-engineering/actions/runs/4638642279
cc @lcartey
|
@jsinglet Running the MISRA-C and CERT query-suites does not yield anything out of the ordinary. Could it be your performance testing having a one-off fluke or perhaps something else causing the issue? |
I tried running Update -- ok so I looked deeper and it appears the problem is with a MISRA query, NOT a CERT query. I didn't realize it but it never even reaches CERT before timing out. I'll let you know when I find it... |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
|
@kraiouchkine -- Ok, I tracked it down and the problem query is.... |
|
@kraiouchkine it looks like you don't have this change https://github.com/github/codeql-coding-standards/blob/rc/2.16/c/misra/src/rules/RULE-7-4/StringLiteralAssignedToNonConstChar.ql <--- release version https://github.com/kraiouchkine/codeql-coding-standards/blob/OutOfBounds/c/misra/src/rules/RULE-7-4/StringLiteralAssignedToNonConstChar.ql <-- your version My suggestion is to update your fork to be in sync with the mergeback I just did into You'll need to first merge this PR or cherry pick that change: #293 |
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
rvermeulen
approved these changes
Apr 7, 2023
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
rvermeulen
dismissed stale reviews from jsinglet and lcartey
Incorporate in my review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the C OutOfBounds package.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.