Update CodeQL CLI dependency to 2.11.6. #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernize qlpacks and update to CodeQL 2.8.5
Update to CodeQL 2.9.4
Update to CodeQL 2.10.1
Rename isPOD to isPod to silence deprecation warnings
`XMLElement` and `XMLFile` are deprecated from CodeQL 2.10.4 onwards. `XmlElement` and `XmlFile` are their direct replacements.
Replace `XMLElement` by `XmlElement` and `XMLFile` by `XmlFile`
Replace `NULLMacro` by `NullMacro`
Update to CodeQL 2.11.0
Update expected test output
C++: Pull in the latest version of `TaintedPath.ql` from CodeQL
C++: Accept test changes after CodeQL `scanf` work
Fix references to pack names after pack renaming
This matches the v2.11.6 CodeQL CLI bundle.
Since 2.11.3 pre-release packs have been ignored CodeQL when installing packs. We re-enable this since we use pre-release packs internally (e.g. in the common packs).
This reverts commit 760ccde. This was prematurely included, but was only shipped in 2.12.*.
These were already released with a previous version.
|
/test-performance |
1 similar comment
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
mbaluda
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CodeQL CLI dependency to 2.11.6, which includes updating the
codeql/cpp-alldependency to0.4.6.I have made this update by merging the relevant commits from
nextinto this branch. This should make it easier to identify unmerged commits in future (by comparingnextwithmain). Additional commits have been made to ensure full compatibility with CodeQL 2.11.6.The
nextcommits included in this pull request includes those in PR:#149
This was slightly premature, as the related
codeql/cpp-allchange shipped with 2.12.0. However, the change is backwards compatible, and so I've chosen to include it here for simplicity of merging.Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
FIO32-CRelease change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.