Skip to content

Address failing gh release view with subshell #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Address failing gh release view with subshell #435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3881b2
Use a subshell to wrap the gh command
rvermeulen Nov 17, 2023
579e425
Prevent globbing and word splitting
rvermeulen Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
# Don't fail the step if gh fails to find the release
set +e

release=$(gh release view v$RELEASE_VERSION --json name,isDraft)
release=$( { gh release view "v$RELEASE_VERSION" --json name,isDraft; } || echo "" )
if [[ -z "$release" ]]; then
echo "Release v$RELEASE_VERSION does not exist. Proceeding"
echo "create_draft_release=true" >> "$GITHUB_ENV"
Expand Down