Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misplaced impl. scope and update help files #54

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix misplaced impl. scope and update help files #54

merged 1 commit into from
Aug 16, 2022

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Aug 16, 2022

Description

Reposition implementation_scope where needed and regenerate the respective help files

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

@mbaluda mbaluda marked this pull request as ready for review August 16, 2022 00:22
Copy link
Contributor

@jsinglet jsinglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care of this @mbaluda !!!!!!!

@jsinglet jsinglet merged commit 585acc9 into github:main Aug 16, 2022
@mbaluda mbaluda deleted the mbaluda/implementation_notes branch August 16, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants