M0-1-9
: Exclude more compiler generated statements
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9.
The dead code query was flagging statements which were generated by the extractor. Notably it was flagging a
DeclStmt
which is generated as part of our handling ofstatic_assert
s. TheseDeclStmt
s have no actual declarations, but are not marked asisCompilerGenerated()
. Using aforex
when determining whether aDeclStmt
is dead ensures that we only flag statements with at least one declaration.In addition, I have added an additional exclusion for statements marked as
isCompilerGenerated()
by the extractor. I have not yet seen a case where this happens, but I think it's a good belt-and-braces exclusion.Change request type
.ql
,.qll
,.qls
or unit tests)Rules with added or modified queries
M0-1-9
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.