Java: Add mybatis mapper.xml sql tainted detection #10121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No file However there is https://github.com/github/codeql/tree/main/java/ql/src/experimental/Security/CWE/CWE-089 This seems to have been committed as part of #6319 which was submitted before #6413 Can you clarify what this PR does on top of the code contributed by #6319 ? |
|
Oh,I am so sorry for my misread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I wrote ql to support sql injection dection in mybatis mapper.xml.
Someone used my code in PR6413 I committed last year without notice and has been meraged in experimental/Security/CWE/CWE-089/MybatisXmlSqlTaintedInParam.ql、experimental.semmle.code.java.MybatisSqlTaintedLib.
This commit has been upgraded which solved some question and work well so many times compared with PR6413.