C#: Don't inject compiler flags when dotnet is used to execute an application. #15764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/csharptracerrunapp
branch
2 times, most recently
from
c439a72
to
07cad66
Compare
michaelnebel
force-pushed
the
csharp/csharptracerrunapp
branch
from
07cad66
to
4c27fa3
Compare
hvitved
approved these changes
Mar 1, 2024
michaelnebel
force-pushed
the
csharp/csharptracerrunapp
branch
from
4c27fa3
to
ac4ad0c
Compare
hvitved
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we improve the C# tracer such that eg.
runis not recognised as a dotnet SDK sub-command but rather an argument to the program being executed (ifdotnetis used to invoke an application).Before this change, this worked by accident if the path to the application wasn't absolute (starting with
/).