Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Fix IR destructor calls on JumpStmts #16366

Merged
merged 4 commits into from
Apr 30, 2024
Merged

C++: Fix IR destructor calls on JumpStmts #16366

merged 4 commits into from
Apr 30, 2024

Conversation

MathiasVP
Copy link
Contributor

This fixes an IR generation problem that @jketema was seeing

Commit-by-commit review recommended

@MathiasVP MathiasVP requested a review from a team as a code owner April 30, 2024 14:50
@github-actions github-actions bot added the C++ label Apr 30, 2024
@MathiasVP MathiasVP added no-change-note-required This PR does not need a change note and removed C++ labels Apr 30, 2024
jketema
jketema previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is happy.

@github-actions github-actions bot added the C++ label Apr 30, 2024
@MathiasVP
Copy link
Contributor Author

DCA looks good!

  • A small reduction in inconsistencies
  • 3 lost results.
    • We removed a double free FP that was likely broken because of the continue further up in the function, which now works correctly
    • Similarly, we removed two use-after-free that were likely broken because of a continue just before the free

@MathiasVP MathiasVP merged commit 3a2b0a2 into github:main Apr 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @jketema