Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Use entities in reorder directives #16418

Merged
merged 1 commit into from
May 17, 2024
Merged

C++: Use entities in reorder directives #16418

merged 1 commit into from
May 17, 2024

Conversation

cklin
Copy link
Contributor

@cklin cklin commented May 3, 2024

This PR changes reorder directives in upgrade/downgrade scripts to use proper entity type names, instead of using int as generic stand-in for entity types.

@github-actions github-actions bot added the C++ label May 3, 2024
@geoffw0 geoffw0 self-assigned this May 8, 2024
@geoffw0 geoffw0 mentioned this pull request May 8, 2024
Merged
@cklin cklin marked this pull request as ready for review May 13, 2024 16:24
@cklin cklin requested a review from a team as a code owner May 13, 2024 16:24
geoffw0
geoffw0 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cklin cklin merged commit f104760 into main May 17, 2024
13 checks passed
@cklin cklin deleted the cklin/cpp-entities-reorder branch May 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees

@geoffw0 geoffw0

Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cklin @geoffw0