Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-sitter: Respect verbosity defined in CODEQL_VERBOSITY #16451

Merged
merged 2 commits into from
May 24, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 8, 2024

No description provided.

@hvitved hvitved force-pushed the treesitter/codeql-verbosity branch from abc186f to e0d40ce Compare May 23, 2024 11:31
@hvitved hvitved force-pushed the treesitter/codeql-verbosity branch from e0d40ce to e4cd9d8 Compare May 23, 2024 11:38
@hvitved hvitved added the no-change-note-required This PR does not need a change note label May 23, 2024
@hvitved hvitved marked this pull request as ready for review May 23, 2024 12:46
@hvitved hvitved requested review from a team as code owners May 23, 2024 12:46
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +27 to +31
"off" | "errors" => "error",
"warnings" => "warn",
"info" | "progress" => "info",
"debug" | "progress+" => "debug",
"trace" | "progress++" | "progress+++" => "trace",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit curious about these levels. They match the ones we support in the Python extractor, but in that case we included things like debug and trace because these were already existing concepts in the Python extractor. Is this also true of the Rust extractor? If not, it might be more sensible to only support the CodeQL CLI default (but to my mind somewhat opaque) progress{+,++} levels.

(Also, mapping off to error seems a bit odd. What if someone wants to turn errors off?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question; I simply took the ones that the C# extractor supports (which matches those supported by the Python extractor).

Regarding off, I choose error because that appears to be the lowest supported level.

@hvitved hvitved merged commit 0dbce3d into github:main May 24, 2024
37 checks passed
@hvitved hvitved deleted the treesitter/codeql-verbosity branch May 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note QL-for-QL Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants