-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-sitter: Respect verbosity defined in CODEQL_VERBOSITY
#16451
Conversation
abc186f
to
e0d40ce
Compare
e0d40ce
to
e4cd9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"off" | "errors" => "error", | ||
"warnings" => "warn", | ||
"info" | "progress" => "info", | ||
"debug" | "progress+" => "debug", | ||
"trace" | "progress++" | "progress+++" => "trace", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit curious about these levels. They match the ones we support in the Python extractor, but in that case we included things like debug
and trace
because these were already existing concepts in the Python extractor. Is this also true of the Rust extractor? If not, it might be more sensible to only support the CodeQL CLI default (but to my mind somewhat opaque) progress{+,++}
levels.
(Also, mapping off
to error
seems a bit odd. What if someone wants to turn errors off?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question; I simply took the ones that the C# extractor supports (which matches those supported by the Python extractor).
Regarding off
, I choose error
because that appears to be the lowest supported level.
No description provided.