Go: fix hasQualifiedName and models-as-data for built-in functions
#16458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that when we don't change the test results every time we add a summary model for a built-in function.
smowton
approved these changes
May 9, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasQualifiedNamebecause technically they do not belong to any package. Now you can use the empty string as the package, e.g.f.hasQualifiedName("", "len").I've pulled this commit out of #16413 so that it can be reviewed in isolation. I don't think it needs a test because it is tested by that PR, which gets our only MaD models for built-in functions working properly.
I don't think there is any need for performance testing, but I can do it if someone wants it.