C#: Make the flow summary filtering in the adapter. #16520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the current logic for dataflow applied to summarized callables is inconsistent.
The following can happen:
If a callable in source is also considered a summarized callable because there exist a summary of a super implementation that apply to all overrides, then the source callable will not be included in
DataFlowSummarizedCallable
.However, the callable will get summary nodes for the parameters and return, which will cause the
uniqueEnclosingCallable
test to fail (as there doesn't exist a correspondingDataFlowSummarizedCallable
for the parameter and return summary nodes).Instead of aligning the summary node and dataflow summarised callable implementation, it seems more consistent (and to ensure code cohesion) to move the exclusion logic to the adapter.
Another solution could be to add branch condition for summary nodes