This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Update query for focusable elements #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraham
approved these changes
Apr 2, 2019
mislav
approved these changes
Apr 3, 2019
| static get CLOSE_SELECTOR() { | ||
| return CLOSE_SELECTOR | ||
| } | ||
| static get INPUT_SELECTOR() { |
There was a problem hiding this comment.
Any reason why this was part of the element's API? 😕
There was a problem hiding this comment.
See #11. I should've questioned it more. 😔
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26.
References:
delegatesFocusis only supported in Chrome with an unclear future 😓 .tabIndexClarify "focusable" in the context of tabIndex IDL attribute whatwg/html#4464, note howdelegatesFocushost hastabIndexof 0 in Chrome.cc @bennypowers