This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Grammar, JSON, and status code corrections #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ curl "https://api.github.com/orgs/github" { "public_gists": 0, "type": "Organization", "public_repos": 55, "url": "https://api.github.com/orgs/github", "blog": "https://github.com/about", "avatar_url": "https://secure.gravatar.com/avatar/...", "company": null, "login": "github", "email": "support@github.com", "followers": 674, "name": "GitHub", "created_at": "2008-05-11T04:37:31Z", "location": "San Francisco, CA", "id": 9919, "following": 0, "html_url": "https://github.com/github" } Note that url is not https://api.github.com/orgs/1 (or any numeral for that matter). This holds the pattern of https://api.github.com/users/github (I shortened the avatar_url link since it wasn't relevant.)
API actually returns status code 200.
So far, just from looking at commits on Pull Requests, it seems as if the 'author' and 'committer' fields are returning USER like data structures instead of the structure that was there previously.
I'm not entirely sure yet that this is the response that is sent, but I'm guessing that it is. I would have expected this to be documented, but I hope this will get the attention of someone who can fix it if it isn't correct.
|
820c3bd was wrong. I hadn't read the surrounding documentation well enough. |
|
Yup, thanks! I'll just merge those commits manually and skip 820c3bd. |
|
No problem. |
This was referenced Nov 16, 2020
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/this/these on a couple lines in content/v3/orgs/teams.md
Also added a correction to the ORG json. The original url link was incorrect.
And finally, for editing a team, the status code that is actually returned is 200, not 201.