Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the configuration page for self-hosted runners to Linux #136

Closed
1 of 8 tasks
jenschelkopf opened this issue May 20, 2020 · 13 comments
Closed
1 of 8 tasks

Default the configuration page for self-hosted runners to Linux #136

jenschelkopf opened this issue May 20, 2020 · 13 comments
Labels
engineering Will involve Docs Engineering stale There is no recent activity on this issue or pull request

Comments

@jenschelkopf
Copy link
Contributor

Issue overview

The 'Configuring the self-hosted runner application as a service' page has tabs for specific instructions for Mac, Windows, and Linux.

Currently, the default tab is Mac.

Let's change the default to Linux, as this is the most common for our users.

image

Products affected by this issue

to be completed by the core product docs team first responder

  • Dotcom (all products)
    • GitHub Free
    • GitHub Pro
    • GitHub Team
  • GitHub Enterprise Cloud
  • GitHub Enterprise Server (Versions: )
  • API
  • Desktop

Note: The doctocat who triages this issue may invite you to open a PR to address it. Doing so is absolutely not required, though it's helpful for a speedy fix! Someone from our team will work with you to take your changes across the finish line.

/cc @github/product-docs-core

@megbird
Copy link
Contributor

megbird commented May 21, 2020

@jenschelkopf, while I don't disagree, I don't think there is any way to set a default tab. @github/content-platform-engineering, I've looked in our internal docs but didn't see much information on the context switcher--can y'all confirm that there is technically no way to do this?

If not, we could change the order of the tabs to where linux is first, if no one minds the switcher OS order won't be consistent in our docs. Adding this to our bug fix board 😄

@zeke
Copy link
Contributor

zeke commented May 21, 2020

This seems like reasonable request to me. We could consider introduce a new frontmatter value like defaultPlatform or similar, which would allow content authors to specify this on any articles that need it.

@timeyoutakeit
Copy link
Contributor

I believe this is an engineering issue rather than content (fwiw, it looks like Linux does appear first in the content)

@zeke
Copy link
Contributor

zeke commented Sep 10, 2020

this is an engineering issue

agreed 👍🏼

@zeke zeke transferred this issue from another repository Oct 6, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 6, 2020
@zeke zeke added engineering Will involve Docs Engineering and removed triage Do not begin working on this issue until triaged by the team labels Oct 6, 2020
@Simran-B
Copy link
Contributor

Simran-B commented Oct 8, 2020

it looks like Linux does appear first in the content

What determines the order of the tabs? If it's not the content, and if it's also not sorted alphabetically (it's Mac, Windows, Linux in above screenshot), then how does the current tab order come about?

@zeke
Copy link
Contributor

zeke commented Oct 8, 2020

What determines the order of the tabs?

Here's the HTML for the tabs: https://github.com/github/docs/blob/5395b9371056e7c8eb9b649e5c1de4de80613155/includes/article.html#L31:L40

Here's the JavaScript file that dynamically updates the tabs and the displayed content on page load: https://github.com/github/docs/blob/main/javascripts/display-platform-specific-content.js

Here's the file where tests should be added for any changes to the existing platform-switching behavior: https://github.com/github/docs/blob/main/tests/browser/browser.js (Note that the platform-switching feature was added before we added this Puppeteer headless browser testing capability, so there are no existing browser tests for the current platform-switching functionality)

I hope that helps, @Simran-B!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@Simran-B
Copy link
Contributor

Simran-B commented Dec 9, 2020

Thanks @zeke for all the information! I created a PR: #1917

Currently, the default tab is Mac.

This isn't the case (anymore?), the default tab is based on the user's operating system, which falls back to Mac if it's none of the supported platforms.

@jenschelkopf
Copy link
Contributor Author

IMO, the tab should not default to the user's OS. The user's OS is not related to the user's runner type. Linux is by far the most common runner type, so we should default to Linux always.

@Simran-B
Copy link
Contributor

Simran-B commented Dec 10, 2020

I agree that it does not make sense for runners, but what about pages like this one?
https://docs.github.com/en/free-pro-team@latest/desktop/installing-and-configuring-github-desktop/getting-started-with-github-desktop

For the actions docs, Linux can be set as defaultPlatform with my PR on a per page basis.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 8, 2021
@janiceilene
Copy link
Contributor

It looks like the work for this one was completed in #1917, so I'm going to close this out!

@Simran-B
Copy link
Contributor

Simran-B commented Feb 9, 2021

Yup, see the documentation about the defaultPlatform frontmatter here: https://github.com/github/docs/blob/main/content/README.md#defaultplatform

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
* Fixes broken links

* Use `:currentVersion:` in links in API docs.

* Use full URL rather than relative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering stale There is no recent activity on this issue or pull request
Projects
None yet
Development

No branches or pull requests

6 participants