-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default the configuration page for self-hosted runners to Linux #136
Comments
@jenschelkopf, while I don't disagree, I don't think there is any way to set a default tab. @github/content-platform-engineering, I've looked in our internal docs but didn't see much information on the context switcher--can y'all confirm that there is technically no way to do this? If not, we could change the order of the tabs to where linux is first, if no one minds the switcher OS order won't be consistent in our docs. Adding this to our bug fix board 😄 |
This seems like reasonable request to me. We could consider introduce a new frontmatter value like |
I believe this is an engineering issue rather than content (fwiw, it looks like Linux does appear first in the content) |
agreed 👍🏼 |
What determines the order of the tabs? If it's not the content, and if it's also not sorted alphabetically (it's Mac, Windows, Linux in above screenshot), then how does the current tab order come about? |
Here's the HTML for the tabs: https://github.com/github/docs/blob/5395b9371056e7c8eb9b649e5c1de4de80613155/includes/article.html#L31:L40 Here's the JavaScript file that dynamically updates the tabs and the displayed content on page load: https://github.com/github/docs/blob/main/javascripts/display-platform-specific-content.js Here's the file where tests should be added for any changes to the existing platform-switching behavior: https://github.com/github/docs/blob/main/tests/browser/browser.js (Note that the platform-switching feature was added before we added this Puppeteer headless browser testing capability, so there are no existing browser tests for the current platform-switching functionality) I hope that helps, @Simran-B! |
This issue is stale because it has been open 60 days with no activity. |
IMO, the tab should not default to the user's OS. The user's OS is not related to the user's runner type. Linux is by far the most common runner type, so we should default to Linux always. |
I agree that it does not make sense for runners, but what about pages like this one? For the actions docs, Linux can be set as defaultPlatform with my PR on a per page basis. |
This issue is stale because it has been open 60 days with no activity. |
It looks like the work for this one was completed in #1917, so I'm going to close this out! |
Yup, see the documentation about the |
* Fixes broken links * Use `:currentVersion:` in links in API docs. * Use full URL rather than relative.
Issue overview
The 'Configuring the self-hosted runner application as a service' page has tabs for specific instructions for Mac, Windows, and Linux.
Currently, the default tab is Mac.
Let's change the default to Linux, as this is the most common for our users.
Products affected by this issue
to be completed by the core product docs team first responder
Note: The doctocat who triages this issue may invite you to open a PR to address it. Doing so is absolutely not required, though it's helpful for a speedy fix! Someone from our team will work with you to take your changes across the finish line.
/cc @github/product-docs-core
The text was updated successfully, but these errors were encountered: