-
Notifications
You must be signed in to change notification settings - Fork 63k
Closed
Labels
actionsThis issue or pull request should be reviewed by the docs actions teamThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamhelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue
Description
Code of Conduct
- I have read and agree to the GitHub Docs project's Code of Conduct
What article on docs.github.com is affected?
- Live doc: Workflow Commands for GitHub Actions: Masking a value in a log
- In repo: workflow-commands-for-github-actions.md
What part(s) of the article would you like to see updated?
In the following linked comments @ericsampson mentions best practice use of the ::add-mask::
command. This is important because improper use (as noted in the issue) could result in exfiltration of plaintext secret values in workflow logs before being masked. The documentation at its current state doesn't make this clear enough and an explicit callout could save implementation time and ensure proper use.
Additional information
- usage of add-mask still echoes the value to the log actions/runner#475 (comment)
- usage of add-mask still echoes the value to the log actions/runner#475 (comment)
- usage of add-mask still echoes the value to the log actions/runner#475 (comment)
- usage of add-mask still echoes the value to the log actions/runner#475 (comment)
sammcj
Metadata
Metadata
Assignees
Labels
actionsThis issue or pull request should be reviewed by the docs actions teamThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamhelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue