-
Notifications
You must be signed in to change notification settings - Fork 63.1k
Description
Code of Conduct
- I have read and agree to the GitHub Docs project's Code of Conduct
What article on docs.github.com is affected?
What part(s) of the article would you like to see updated?
In both pages linked about, it says that if you don't specify the port, it maps the host port to a randomly chosen port on the container:
About service containers / Mapping Docker host and service container ports
❌
8080/udp
Map a randomly chosen UDP port in the container to UDP port 8080 on the Docker host.
I think, it's the other way around: "Map a randomly chosen port on the Docker host to UDP port 8080 in the container"
Workflow syntax for GitHub Actions / jobs.<job_id>.services
/ Example: Using localhost
❌ When you specify the Docker host port but not the container port, the container port is randomly assigned to a free port.
I think, it should be: "When you specify the container port but not the Docker host port, the container port is randomly assigned to a free port."
Additional information
In the following page, I think the correct statement is used:
✅ This example workflow configures a PostgreSQL service container, and automatically maps port 5432 in the service container to a randomly chosen available port on the host.