-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all-contributors configuration to avoid merge conflicts #527
Comments
Makes sense to me. The unintended change here would be that the core maintainers of the project aren't listed first like we are now, but I think that's okay. |
☝🏼 Yeah I was thinking that. Maybe there's a hybrid way to approach this, where the source JSON data in |
The readme's are the easier spot to end up with yaml mistakes when resolving conflicts. The JSON doesn't ever require any real updates. Honestly, it's annoying and unfortunate, but mostly not a real problem 🙃 |
Might be worth adding an auto-land action for those PRs from their bot. They the conflicts are less likely crop up then as well |
We're removing all-contributors for now 😞 Our small team just can't keep up with the (amazing!) influx of contributions. There's more details available in #576 (review) and this issue should definitely stay open so we can figure out how to resolve this complexity and get something back up and running 🙌 |
Probably makes sense to close the open PRs https://github.com/github/docs/pulls/app%2Fallcontributors |
There are also some leftover branches in https://github.com/github/docs/branches/all |
No longer using all-contributors. |
When adding a new contributor to the project using
@all-contributors please add @user for docs
, the user's name is appended to the end of thecontributors
array in the.all-contributorsrc
file. This is problematic because two separate PRs will likely conflict, as they are both modifying the same part of the file.We may be able to work around this using the
contributorsSortAlphabetically
option, which appears to be supported by both the CLI and the GitHub bot:cc @github/docs-engineering @janiceilene
The text was updated successfully, but these errors were encountered: