Skip to content

Add warning about env vars defined via others #15622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2022
Merged

Add warning about env vars defined via others #15622

merged 4 commits into from
Mar 3, 2022

Conversation

FlashSheridan
Copy link
Contributor

Why:

Variables in the env map cannot be defined in terms of other variables in the map, which may surprise those used to regular shell environment variables.

What's being changed:

Add note to documentation.

@FlashSheridan
Add warning about env vars defined via others
10c25fe 
Note that variables in the `env` map cannot be defined in terms of other variables in the map.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 18, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 21, 2022
@ramyaparimi
Copy link
Contributor

@FlashSheridan
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ethomson
Copy link
Contributor

ethomson commented Mar 1, 2022

This makes sense. Thanks!

@FlashSheridan
rm suggestion about non-Bash shell
7310947 
…and complex manipulation of variables.

Co-authored-by: Edward Thomson <ethomson@github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/using-workflows/workflow-syntax-for-github-actions.md Modified Original

lecoursen
lecoursen previously approved these changes Mar 3, 2022
View reviewed changes
@lecoursen lecoursen enabled auto-merge March 3, 2022 18:47
@lecoursen lecoursen merged commit 21ffb0b into github:main Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

+1 more reviewer

@ethomson ethomson ethomson left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlashSheridan @ramyaparimi @ethomson @lecoursen