Skip to content

repo sync #17424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2022
Merged

repo sync #17424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e087622
REST Docs: update H3 to H2 operation heading (#27242)
gracepark Apr 27, 2022
bed5f40
Updating main (#27291)
roferg Apr 27, 2022
d47f416
Merge branch 'main' into repo-sync
Octomerger Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/rest/RestOperationHeading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ type Props = {
export function RestOperationHeading({ slug, title, descriptionHTML }: Props) {
return (
<>
<h3 id={slug}>
<h2 id={slug}>
<a href={`#${slug}`}>
<LinkIcon size={16} className="m-1" />
</a>
{title}
</h3>
</h2>
<div dangerouslySetInnerHTML={{ __html: descriptionHTML }} />
</>
)
Expand Down
8 changes: 4 additions & 4 deletions tests/rendering/rest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ import { getDiffOpenAPIContentRest } from '../../script/rest/test-open-api-schem
describe('REST references docs', () => {
jest.setTimeout(3 * 60 * 1000)

// Checks that every version of the /rest/references/checks
// Checks that every version of the /rest/checks
// page has every operation defined in the openapi schema.
test('loads schema data for all versions', async () => {
for (const version in allVersions) {
const checksRestOperations = await getRest(version, 'checks', 'runs')
const $ = await getDOM(`/en/${version}/rest/checks/runs`)
const domH3Ids = $('h3')
.map((i, h3) => $(h3).attr('id'))
const domH2Ids = $('h2')
.map((i, h2) => $(h2).attr('id'))
.get()
const schemaSlugs = checksRestOperations.map((operation) => slugger.slug(operation.title))
expect(schemaSlugs.every((slug) => domH3Ids.includes(slug))).toBe(true)
expect(schemaSlugs.every((slug) => domH2Ids.includes(slug))).toBe(true)
}
})

Expand Down