Skip to content

Add 'converted_to_draft' action to the pull request webhook payload documentation #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2021
Merged

Add 'converted_to_draft' action to the pull request webhook payload documentation #2417

merged 2 commits into from
Jan 29, 2021

Conversation

recurser
Copy link
Contributor

@recurser recurser commented Dec 29, 2020 •
edited
Loading

Why:

See #2416

There is an action called converted_to_draft that is not documented here:

Can be one of opened, edited, closed, assigned, unassigned, review_requested, review_request_removed, ready_for_review, labeled, unlabeled, synchronize, locked, unlocked, or reopened.

This is the reverse of the ready_for_review action that is already documented - triggered when a pull request is converted back to a draft.

This has a follow-on effect in the octokit/webhooks.js library since the Typescript types are generated from Github documentation.

103186705-e07e4300-4904-11eb-9b5c-8c411d07b167

What's being changed:

The converted_to_draft action has been added to the list of actions, in the base documentation and existing translations.

Edit: I reverted the changes to the translations as requested by the bot.

See the updated documentation on the Heroku review app here.

Check off the following:

@recurser recurser requested review from a team as code owners December 29, 2020 05:53
@welcome
Copy link

welcome bot commented Dec 29, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the localization Issue or PR relating to translation or localization label Dec 29, 2020
github-actions[bot]
github-actions bot previously requested changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.

  • translations/de-DE/data/reusables/webhooks/pull_request_webhook_properties.md
  • translations/es-XL/data/reusables/webhooks/pull_request_webhook_properties.md
  • translations/ja-JP/data/reusables/webhooks/pull_request_webhook_properties.md
  • translations/ko-KR/data/reusables/webhooks/pull_request_webhook_properties.md
  • translations/pt-BR/data/reusables/webhooks/pull_request_webhook_properties.md
  • translations/ru-RU/data/reusables/webhooks/pull_request_webhook_properties.md
  • translations/zh-CN/data/reusables/webhooks/pull_request_webhook_properties.md

You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

It looks like you've modified translated content. Unfortunately, we are not able to accept pull requests for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open source community, but we're not there yet. See https://github.com/github/docs/blob/main/CONTRIBUTING.md#earth_asia-translations for more details.

@recurser recurser force-pushed the add-converted-to-draft-action-to-pull-request-payload branch from ac4fdad to a60c166 Compare December 29, 2020 05:55
This was referenced Dec 29, 2020
Closed
Closed
@janiceilene
Copy link
Contributor

@recurser Thanks so much for following the trail and opening an issue and PR 💖 I'll get this triaged for review!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team and removed localization Issue or PR relating to translation or localization labels Dec 29, 2020
@recurser recurser mentioned this pull request Jan 1, 2021
Closed
@wolfy1339 wolfy1339 mentioned this pull request Jan 2, 2021
Merged
@heiskr heiskr removed the request for review from a team January 5, 2021 02:24
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@wolfy1339
Copy link
Contributor

This isn't stale. Waiting on review from the required person/team

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 20, 2021
@wolfy1339
Copy link
Contributor

This isn't stale. Waiting on review from the required person/team

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 20, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@wolfy1339
Copy link
Contributor

This isn't stale. Waiting on review from the required person/team

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@skedwards88 skedwards88 self-assigned this Jan 29, 2021
skedwards88
skedwards88 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you for making this change and thank you for your patience while we work through reviews! I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jan 29, 2021
@skedwards88
Copy link
Contributor

Closes #2416

@skedwards88 skedwards88 merged commit 4791bf1 into github:main Jan 29, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

@Vargas11484 Vargas11484 Vargas11484 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@skedwards88 skedwards88

Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@recurser @janiceilene @wolfy1339 @skedwards88 @Vargas11484