Skip to content

Conversation

hayden-t
Copy link
Contributor

Why:

Highlights an easily missed security vulnerability

What's being changed (if available, include any code snippets, screenshots, or gifs):

ive tested this, and unless codeowners is itself protected by codeowners, rules can be changed....

Check off the following:

  • [yes ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [yes ] For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Nov 30, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 30, 2023
Copy link
Contributor

github-actions bot commented Nov 30, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@steveward steveward added content This issue or pull request belongs to the Docs Content team code owners Content related to code owners repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 30, 2023
@steveward
Copy link
Member

Thanks for the PR @hayden-t. I'll get this triaged for review. ⚡

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hayden-t - many thanks for flagging how to use your CODEOWNERS file more securely for branch protection 💖

I'm going to merge a couple of changes to bring the content into line with our current style guide and recheck the preview. If that looks okay, then we should be able to merge your changes.

…atures/customizing-your-repository/about-code-owners.md
@felicitymay felicitymay enabled auto-merge January 11, 2024 18:28
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. It will help our users create more secure repositories.

@felicitymay felicitymay added this pull request to the merge queue Jan 11, 2024
Merged via the queue into github:main with commit fc180ea Jan 11, 2024
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code owners Content related to code owners content This issue or pull request belongs to the Docs Content team repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants