-
Notifications
You must be signed in to change notification settings - Fork 63.2k
Avoid codesign modal keychain password dialog #30252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid codesign modal keychain password dialog #30252
Conversation
Following lines are pasted from `man security` ran on macOS 14.0: ```console set-key-partition-list [-S <partition list (comma separated)>] [-k <keychain password>] [options...] [keychain] Sets the "partition list" for a key. The "partition list" is an extra parameter in the ACL which limits access to the key based on an application's code signature. You must present the keychain's password to change a partition list. If you'd like to run /usr/bin/codesign with the key, "apple:" must be an element of the partition list. -S partition-list Comma-separated partition list. See output of "security dump-keychain" for examples. -k password Password for keychain -a application-label Match "application label" string -c creator Match creator (four-character code) -d Match keys that can decrypt -D description Match "description" string -e Match keys that can encrypt -j comment Match comment string -l label Match label string -r Match keys that can derive -s Match keys that can sign -t type Type of key to find: one of "symmetric", "public", or "private" -u Match keys that can unwrap -v Match keys that can verify -w Match keys that can wrap ``` See: 1. https://github.com/Apple-Actions/import-codesign-certs/blob/5565bb656f60c98c8fc515f3444dd8db73545dc2/src/security.ts#L121-L141
@hrishikesh-kadam Hello! 👋 Apologies for our delay in getting back to you! We are asking our team about this internally, and will respond once we have more information 💛 Internal: asked here |
@hrishikesh-kadam Thank you very much for your patience while we reviewed this PR! The changes look great ✨ I'll update the branch and get this merged once tests are passing 🍏 |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Following lines are pasted from
man security
ran on macOS 14.0:See:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Doc Link: https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.Preview Link: https://docs-30252-d1abb2.preview.ghdocs.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development